Makes PlanetaryConditionsDialog work again after scaling stuff #6094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6094 +/- ##
=========================================
Coverage 29.11% 29.11%
- Complexity 13978 13979 +1
=========================================
Files 2601 2601
Lines 267121 267123 +2
Branches 47748 47748
=========================================
+ Hits 77769 77771 +2
+ Misses 185446 185443 -3
- Partials 3906 3909 +3 ☔ View full report in Codecov by Sentry. |
kuronekochomusuke
approved these changes
Oct 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: PlanetaryConditionsDialog, the one you get from the button in the map section of the lobby, started spawning 1 pixel wide by about 50 pixels tall in the upper left corner of my screen. This makes it very difficult to use
Cause: Scaling-related changes to ClientDialog, possibly 4e9c487
Fix: Add
pack()andcenter()to the PlanetaryConditionsDialog like other ClientDialogs have.